Implement Hiring Hall Overrides #5069
Merged
+186
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Algebro7
force-pushed
the
hiring-hall-overrides
branch
from
b28b20d
to
44e2aa4
Compare
|
@IllianiCBT flipping this to ready for review as I resolved the marshalling bugs. Turned out to be a simple data entry error in systems.xml. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5069 +/- ##
=========================================
Coverage 10.43% 10.44%
- Complexity 6041 6043 +2
=========================================
Files 953 955 +2
Lines 134112 134142 +30
Branches 19435 19439 +4
=========================================
+ Hits 13996 14007 +11
- Misses 118772 118790 +18
- Partials 1344 1345 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a static list of hiring halls with dates to systems.xml. The hiringHall node is embedded in the relevant system node. This allows us to override the dynamic hiring hall system for certain worlds like Outreach.